maropu commented on a change in pull request #29085:
URL: https://github.com/apache/spark/pull/29085#discussion_r456460672
##########
File path:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/HiveScriptTransformationExec.scala
##########
@@ -172,19 +237,17 @@ case class HiveScriptTransformationExec(
if (!hasNext) {
throw new NoSuchElementException
}
- if (outputSerde == null) {
+ nextRow()
+ }
+
+ val nextRow: () => InternalRow = if (outputSerde == null) {
Review comment:
hm... could we write it like this here?
https://github.com/maropu/spark/commit/f3e05c6e1ea1e195ff2cbc9e3aa70c45cf9cc79f
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
