cloud-fan commented on a change in pull request #29143:
URL: https://github.com/apache/spark/pull/29143#discussion_r456466819
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala
##########
@@ -458,6 +458,7 @@ abstract class SparkStrategies extends
QueryPlanner[SparkPlan] {
// [COUNT(DISTINCT bar), COUNT(DISTINCT foo)] is disallowed
because those two distinct
// aggregates have different column expressions.
val distinctExpressions =
functionsWithDistinct.head.aggregateFunction.children
+ .filterNot(_.foldable)
Review comment:
I tried `select count(distinct 1) from v group by id` but works fine, I
think `foldable` is not the real problem here. I think the root cause is,
FIRST/LAST put `ignoreNulls` as its children while the children are supposed to
be the function inputs.
How about this fix
```
case class First(child: Expression, ignoreNulls: Boolean)
extends DeclarativeAggregate with ExpectsInputTypes {
def this(child: Expression) = this(child, false)
def this(child: Expression, ignoreNullsExpr: Expression) = {
this(child, First.validateIgnoreNullExpr(ignoreNullsExpr)) // follow
HyperLogLogPlusPlus.validateDoubleLiteral
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
