cloud-fan commented on a change in pull request #29130:
URL: https://github.com/apache/spark/pull/29130#discussion_r456479893
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/ShuffledHashJoinExec.scala
##########
@@ -47,6 +47,18 @@ case class ShuffledHashJoinExec(
"buildDataSize" -> SQLMetrics.createSizeMetric(sparkContext, "data size of
build side"),
"buildTime" -> SQLMetrics.createTimingMetric(sparkContext, "time to build
hash map"))
+ override def outputPartitioning: Partitioning = joinType match {
Review comment:
This is exactly the same as SMJ. Shall we create a common trait
`ShuffleJoin` to put it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
