dongjoon-hyun commented on a change in pull request #29089:
URL: https://github.com/apache/spark/pull/29089#discussion_r456531088
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
##########
@@ -969,11 +969,11 @@ object CombineFilters extends Rule[LogicalPlan] with
PredicateHelper {
* Removes Sort operation. This can happen:
Review comment:
Shall we revise this line?
```scala
- Removes Sort operation. This can happen:
+ Removes Sort operation if it doesn't affect the final output ordering.
+ Note that the final output ordering changes and affect the file size
(SPARK-32318).
+ This optimizer handles the following cases:
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
