Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5173#discussion_r27260345
  
    --- Diff: python/pyspark/cloudpickle.py ---
    @@ -40,164 +40,126 @@
     NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
     SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
     """
    -
    +from __future__ import print_function
     
     import operator
     import os
    +import io
     import pickle
     import struct
     import sys
     import types
     from functools import partial
     import itertools
    -from copy_reg import _extension_registry, _inverted_registry, 
_extension_cache
    -import new
     import dis
     import traceback
    -import platform
    -
    -PyImp = platform.python_implementation()
    -
     
    -import logging
    -cloudLog = logging.getLogger("Cloud.Transport")
    --- End diff --
    
    In the past, I think we had held off from doing massive refactorings in 
this file in the hopes that it would simplify merging of patches from upstream 
cloudpickle, but it turns out that we never needed to do that (and PyCloud has 
now shut down, so that's not going to happen).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to