Github user dbtsai commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4259#discussion_r27260459
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/param/sharedParams.scala 
---
    @@ -34,6 +34,43 @@ private[ml] trait HasRegParam extends Params {
       def getRegParam: Double = get(regParam)
     }
     
    +private[ml] trait HasElasticNetParam extends HasRegParam {
    --- End diff --
    
    Sounds great! I'm convinced to do something like
    
    ```scala
    private[ml] trait HasElasticNetParam extends HasRegParam {
      /**
       * param for elastic net regularization parameter
       * @group param
       */
      val elasticNetParam: DoubleParam =
        new DoubleParam(this, "elasticNetParam", "the ElasticNet mixing 
parameter")
    
      /** @group getParam */
      def getElasticNetParam: Double = get(elasticNetParam)
    }
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to