Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/5173#issuecomment-86738233
I took a very fast, shallow patch through these changes. Most of them seem
pretty straightforward (e.g. using the print function, working around the
removal of the tuple-unpacking syntax, etc.). I'll definitely want to spend a
bit more time reviewing the cloudpickle changes and any Scala-side changes.
One high-level comment: I noticed that Python 3 drops a bunch of the
itertools methods in favor of having the regular functions return iterators.
If we just replace `map` with `imap`, will we risk introducing performance
regressions from Python 2.x? I wonder if we should just do something like
`imap = map` for Python 3 instead of using `map` for Python 2.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
