Github user brennonyork commented on the pull request:
https://github.com/apache/spark/pull/5093#issuecomment-86747670
/cc @pwendell @srowen @nchammas
All complete. You can check out build 29250 up a few to get what the output
would be like if a new dependency were added. One issue which I'd love to get
some opinion on...
Right now the initial post message to Github (i.e. the "Test build started
+ patch merges cleanly") will take up to 20 minutes to post **if** any
`pom.xml` files were changed because it will then run and build both the
current PR plus the master branch. This is purely because the "This patch
merges cleanly" output is from a `pr_test` and runs in the core test loop. The
easiest option to reflect the original way things have been posted would be to
move the `pr_merge_ability` test out of the main test loop and have it execute
independently. The other option would be to merely post the "Test build started
at ..." message and remove the "merges cleanly" portion to be posted with in
the post-test message.
I'll admit I'm more in favor of the latter option as I think it keeps
things clean as well as the fact that "merges cleanly" is slightly ambiguous
given that Github reports on this as well. Thoughts? Whichever way we go I can
get that final change up and then I'd say this is ready for review into master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
