HyukjinKwon commented on a change in pull request #29143:
URL: https://github.com/apache/spark/pull/29143#discussion_r456848709
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/First.scala
##########
@@ -120,3 +120,11 @@ case class First(child: Expression, ignoreNullsExpr:
Expression)
override def toString: String = s"$prettyName($child)${if (ignoreNulls) "
ignore nulls"}"
}
+
+object FirstLast {
Review comment:
I think this deduplication is a little bit too much but I guess it's
fine.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
