TJX2014 commented on a change in pull request #29156:
URL: https://github.com/apache/spark/pull/29156#discussion_r456968128
##########
File path:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala
##########
@@ -2558,6 +2558,14 @@ abstract class SQLQuerySuiteBase extends QueryTest with
SQLTestUtils with TestHi
}
}
}
+
+ test("SPARK-32347: cte hint should be resolved in Hints batch rule") {
+ withTempView("t") {
+ sql("create temporary view t as select 1 as id")
+ sql("with cte as (select /*+ BROADCAST(id) */ id from t) select id from
cte")
Review comment:
@maropu Sure, we can see in branch 2.4, the hint of cte could be
resolved in `CTESubstitution`, we have a chance `executeSameContext` to apply
all rules to CTE include hint resolve, but in branch 3.0, the `CTESubstitution`
is reparated, and the `executeSameContext` is belong to `Analyzer`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
