AngersZhuuuu commented on a change in pull request #29085:
URL: https://github.com/apache/spark/pull/29085#discussion_r456991221
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala
##########
@@ -713,13 +714,18 @@ class SparkSqlAstBuilder(conf: SQLConf) extends
AstBuilder(conf) {
}
(Seq.empty, Option(name), props.toSeq, recordHandler)
- case null =>
+ case null if conf.getConf(CATALOG_IMPLEMENTATION).equals("hive") =>
// Use default (serde) format.
val name = conf.getConfString("hive.script.serde",
"org.apache.hadoop.hive.serde2.lazy.LazySimpleSerDe")
val props = Seq("field.delim" -> "\t")
val recordHandler = Option(conf.getConfString(configKey,
defaultConfigValue))
(Nil, Option(name), props, recordHandler)
+
+ // SPARK-32106: When there is no definition about format, we return
empty result
+ // to use a built-in default Serde in SparkScriptTransformationExec.
+ case null =>
+ (Nil, None, Seq.empty, None)
Review comment:
For your confuse
https://github.com/apache/spark/pull/29085#discussion_r456974391,
CalenderIntervalType/ArrayType/MapType/StructType as input of hive default
serde will throw error, won't throw error in spark default way.
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala
##########
@@ -713,13 +714,18 @@ class SparkSqlAstBuilder(conf: SQLConf) extends
AstBuilder(conf) {
}
(Seq.empty, Option(name), props.toSeq, recordHandler)
- case null =>
+ case null if conf.getConf(CATALOG_IMPLEMENTATION).equals("hive") =>
// Use default (serde) format.
val name = conf.getConfString("hive.script.serde",
"org.apache.hadoop.hive.serde2.lazy.LazySimpleSerDe")
val props = Seq("field.delim" -> "\t")
val recordHandler = Option(conf.getConfString(configKey,
defaultConfigValue))
(Nil, Option(name), props, recordHandler)
+
+ // SPARK-32106: When there is no definition about format, we return
empty result
+ // to use a built-in default Serde in SparkScriptTransformationExec.
+ case null =>
+ (Nil, None, Seq.empty, None)
Review comment:
@maropu For your confuse
https://github.com/apache/spark/pull/29085#discussion_r456974391,
CalenderIntervalType/ArrayType/MapType/StructType as input of hive default
serde will throw error, won't throw error in spark default way.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
