maropu commented on a change in pull request #29104:
URL: https://github.com/apache/spark/pull/29104#discussion_r457092224



##########
File path: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/planning/patterns.scala
##########
@@ -388,3 +390,36 @@ object PhysicalWindow {
     case _ => None
   }
 }
+
+object ExtractSingleColumnNotInSubquery extends JoinSelectionHelper {

Review comment:
       This optimization is related only to sub-queries? Actually, this PR 
targets at null-aware anti-join with a single-column case? e.g., `select * from 
t1 anti join t2 on t1.id = t2.id or isnull(t1.id = t2.id)`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to