leanken commented on pull request #29104:
URL: https://github.com/apache/spark/pull/29104#issuecomment-660991824


   NullAwareAntiJoinSQLQueryTestSuite passed.
   org.apache.spark.sql.JoinSuite passed.
   Manually Test with the following config combination with 
not-in-unit-tests-single-column.sql all passed.
   
       ```
       Map(
         "spark.sql.nullAware.antiJoin.optimize.enabled" -> "true",
         "spark.sql.adaptive.enabled" -> "false",
         "spark.sql.codegen.wholeStage" -> "false",
         "spark.sql.nullAware.antiJoin.optimize.use.bhj" -> "false"
       ),
       Map(
         "spark.sql.nullAware.antiJoin.optimize.enabled" -> "true",
         "spark.sql.adaptive.enabled" -> "false",
         "spark.sql.codegen.wholeStage" -> "true",
         "spark.sql.nullAware.antiJoin.optimize.use.bhj" -> "false"
       ),
       Map(
         "spark.sql.nullAware.antiJoin.optimize.enabled" -> "true",
         "spark.sql.adaptive.enabled" -> "true",
         "spark.sql.codegen.wholeStage" -> "false",
         "spark.sql.nullAware.antiJoin.optimize.use.bhj" -> "false"
       ),
       Map(
         "spark.sql.nullAware.antiJoin.optimize.enabled" -> "true",
         "spark.sql.adaptive.enabled" -> "true",
         "spark.sql.codegen.wholeStage" -> "true",
         "spark.sql.nullAware.antiJoin.optimize.use.bhj" -> "false"
       ),
       Map(
         "spark.sql.nullAware.antiJoin.optimize.enabled" -> "true",
         "spark.sql.adaptive.enabled" -> "false",
         "spark.sql.codegen.wholeStage" -> "false",
         "spark.sql.nullAware.antiJoin.optimize.use.bhj" -> "true"
       ),
       Map(
         "spark.sql.nullAware.antiJoin.optimize.enabled" -> "true",
         "spark.sql.adaptive.enabled" -> "false",
         "spark.sql.codegen.wholeStage" -> "true",
         "spark.sql.nullAware.antiJoin.optimize.use.bhj" -> "true"
       ),
       Map(
         "spark.sql.nullAware.antiJoin.optimize.enabled" -> "true",
         "spark.sql.adaptive.enabled" -> "true",
         "spark.sql.codegen.wholeStage" -> "false",
         "spark.sql.nullAware.antiJoin.optimize.use.bhj" -> "true"
       ),
       Map(
         "spark.sql.nullAware.antiJoin.optimize.enabled" -> "true",
         "spark.sql.adaptive.enabled" -> "true",
         "spark.sql.codegen.wholeStage" -> "true",
         "spark.sql.nullAware.antiJoin.optimize.use.bhj" -> "true"
       )
       ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to