leanken commented on a change in pull request #29104:
URL: https://github.com/apache/spark/pull/29104#discussion_r457786215
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoinExec.scala
##########
@@ -44,7 +45,7 @@ case class BroadcastHashJoinExec(
buildSide: BuildSide,
condition: Option[Expression],
left: SparkPlan,
- right: SparkPlan)
+ right: SparkPlan, isNullAwareAntiJoin: Boolean = false)
Review comment:
> nit: Can you the `isNullAwareAntiJoin` on a new line.
>
> Also, just to make sure: This should show up in the .sql.out files: This
should change the string representation of the node and thus you would probably
need to update some of the `.out` files. I think this should be the intended
behavior.
I've check on the sql.out file format, Node string representation is not
part of the output.
```
* The format for golden result files look roughly like:
* {{{
* -- some header information
*
* -- !query
* select 1, -1
* -- !query schema
* struct<...schema...>
* -- !query output
* ... data row 1 ...
* ... data row 2 ...
* ...
*
* -- !query
* ...
* }}}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
