HyukjinKwon commented on pull request #29172: URL: https://github.com/apache/spark/pull/29172#issuecomment-661605706
If `originalMap` doesn't matter much, I think It's good enough to go with the current PR. If `originalMap` matters, we should think about a different approach but can't come up with a good idea. One idea is https://github.com/apache/spark/pull/29172#issuecomment-661604611 but it has downsides such as being error-prone. Another possible approach is to change signature to something like `mutable.LinkedHashMap` or `immutable.ListMap` where `Map` is used in Spark but seems that'd be pretty invasive and a big change. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
