cloud-fan commented on a change in pull request #29167:
URL: https://github.com/apache/spark/pull/29167#discussion_r457833897
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
##########
@@ -3515,6 +3515,13 @@ class AstBuilder(conf: SQLConf) extends
SqlBaseBaseVisitor[AnyRef] with Logging
}
}
+ val properties =
ctx.tablePropertyList.asScala.headOption.map(visitPropertyKeyValues)
+ .getOrElse(Map.empty)
+ if (ctx.TEMPORARY != null && !properties.isEmpty) {
+ operationNotAllowed(
+ "CREATE TEMPORARY VIEW ... TBLPROPERTIES (property_name =
property_value, ...)", ctx)
Review comment:
I think we should move that check to the parser as well (in a separate
PR). If we support view in DS v2, we shouldn't duplicated the check in both v1
and v2 commands.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
