HyukjinKwon commented on a change in pull request #29174:
URL: https://github.com/apache/spark/pull/29174#discussion_r457834593



##########
File path: launcher/src/main/java/org/apache/spark/launcher/SparkLauncher.java
##########
@@ -70,6 +70,8 @@
   public static final String EXECUTOR_EXTRA_JAVA_OPTIONS = 
"spark.executor.extraJavaOptions";
   /** Configuration key for the executor native library path. */
   public static final String EXECUTOR_EXTRA_LIBRARY_PATH = 
"spark.executor.extraLibraryPath";
+  /** Configuration key for the number of executor instances. */
+  public static final String EXECUTOR_INSTANCES = "spark.executor.instances";

Review comment:
       Can you use this constant in other places? For example, 
`core/src/main/scala/org/apache/spark/internal/config/package.scala`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to