HyukjinKwon edited a comment on pull request #29172:
URL: https://github.com/apache/spark/pull/29172#issuecomment-661637178


   I thought it's better to be safe to always for `originalMap` to contain the 
original map as is, and now it's broken. `originalMap` is an exposed property 
in `CaseInsensitiveMap`.
   
   Now once you combine `CaseInsensitiveMap` with another entry, e.g. 
`(caseInsensitiveMap + ("option" -> 1)`, the `originalMap` removes the 
duplicates such as `Option`, `oPtion`,etc.
   
   Maybe I am too much cautious about it. I agree that it's not going to cause 
an external problem for now.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to