[GitHub] [spark] dongjoon-hyun opened a new pull request #29175: [SPARK-32377][SQL] CaseInsensitiveMap should be deterministic for addition

[GitBox]

dongjoon-hyun opened a new pull request #29175:
URL: https://github.com/apache/spark/pull/29175


   ### What changes were proposed in this pull request?
   
   This PR aims to fix `CaseInsensitiveMap` to be deterministic for addition.
   This is a backporting of https://github.com/apache/spark/pull/29172 .
   
   ### Why are the changes needed?
   
   ```scala
   import org.apache.spark.sql.catalyst.util.CaseInsensitiveMap
   var m = CaseInsensitiveMap(Map.empty[String, String])
   Seq(("paTh", "1"), ("PATH", "2"), ("Path", "3"), ("patH", "4"), ("path", 
"5")).foreach { kv =>
     m = (m + kv).asInstanceOf[CaseInsensitiveMap[String]]
     println(m.get("path"))
   }
   ```
   
   **BEFORE**
   ```
   Some(1)
   Some(2)
   Some(3)
   Some(4)
   Some(1)
   ```
   
   **AFTER**
   ```
   Some(1)
   Some(2)
   Some(3)
   Some(4)
   Some(5)
   ```
   
   ### Does this PR introduce _any_ user-facing change?
   
   Yes, but this is a bug fix on non-deterministic behavior.
   
   ### How was this patch tested?
   
   Pass the newly added test case.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org