agrawaldevesh commented on a change in pull request #29014:
URL: https://github.com/apache/spark/pull/29014#discussion_r457867091
##########
File path: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
##########
@@ -1767,10 +1767,18 @@ private[spark] class DAGScheduler(
// TODO: mark the executor as failed only if there were lots of
fetch failures on it
if (bmAddress != null) {
- val hostToUnregisterOutputs = if
(env.blockManager.externalShuffleServiceEnabled &&
- unRegisterOutputOnHostOnFetchFailure) {
- // We had a fetch failure with the external shuffle service, so
we
- // assume all shuffle data on the node is bad.
+ val externalShuffleServiceEnabled =
env.blockManager.externalShuffleServiceEnabled
+ val isHostDecommissioned = taskScheduler
+ .getExecutorDecommissionInfo(bmAddress.executorId)
+ .exists(_.isHostDecommissioned)
+ // Host shuffle data is considered lost if:
+ // - If we know that the host was decommissioned
+ // - Or when `unRegisterOutputOnHostOnFetchFailure` is enabled and
we had
+ // a fetch failure with the external shuffle service, so we
assume all
+ // shuffle data on the node is bad.
+ val hostLost = isHostDecommissioned ||
(externalShuffleServiceEnabled &&
Review comment:
Edit: @attilapiros thanks for bringing me to rework this. I think I get
the main intention of your suggestion now: unRegisterOutputOnHostOnFetchFailure
now uniformly applies to both normal fetch failures and decommissioning. So the
description does not need to be reworked. Please take a look at the new version.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
