maropu commented on a change in pull request #29166:
URL: https://github.com/apache/spark/pull/29166#discussion_r457934563
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
##########
@@ -1237,20 +1249,44 @@ class Analyzer(
if (conflictPlans.isEmpty) {
right
} else {
- val attributeRewrites = AttributeMap(conflictPlans.flatMap {
- case (oldRelation, newRelation) =>
oldRelation.output.zip(newRelation.output)})
- val conflictPlanMap = conflictPlans.toMap
- // transformDown so that we can replace all the old Relations in one
turn due to
- // the reason that `conflictPlans` are also collected in pre-order.
- right transformDown {
- case r => conflictPlanMap.getOrElse(r, r)
- } transformUp {
- case other => other transformExpressions {
+ rewritePlan(right, conflictPlans.toMap)._1
+ }
+ }
+
+ private def rewritePlan(plan: LogicalPlan, conflictPlanMap:
Map[LogicalPlan, LogicalPlan])
+ : (LogicalPlan, mutable.ArrayBuffer[(Attribute, Attribute)]) = {
Review comment:
Yea, cosmetic changes though, I thought it like this;
```
@@ -1254,16 +1254,15 @@ class Analyzer(
}
private def rewritePlan(plan: LogicalPlan, conflictPlanMap:
Map[LogicalPlan, LogicalPlan])
- : (LogicalPlan, mutable.ArrayBuffer[(Attribute, Attribute)]) = {
- val attrMapping = new mutable.ArrayBuffer[(Attribute, Attribute)]()
+ : (LogicalPlan, Seq[(Attribute, Attribute)]) = {
if (conflictPlanMap.contains(plan)) {
// If the plan is the one that conflict the with left one, we'd
// just replace it with the new plan and collect the rewrite
// attributes for the parent node.
val newRelation = conflictPlanMap(plan)
- attrMapping ++= plan.output.zip(newRelation.output)
- newRelation -> attrMapping
+ newRelation -> plan.output.zip(newRelation.output)
} else {
+ val attrMapping = new mutable.ArrayBuffer[(Attribute, Attribute)]()
var newPlan = plan.mapChildren { child =>
// If not, we'd rewrite child plan recursively until we find the
// conflict node or reach the leaf node.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
