Fokko commented on a change in pull request #29122:
URL: https://github.com/apache/spark/pull/29122#discussion_r458010885
##########
File path: python/pyspark/sql/functions.py
##########
@@ -2392,7 +2393,7 @@ def json_tuple(col, *fields):
@since(2.1)
-def from_json(col, schema, options={}):
+def from_json(col, schema, options: Dict = None):
Review comment:
I'm happy to work on the annotations, but would be great to have some
support from the committers as well. I'm planning to integrate mypy in the CI
as well, so we can enforce the type checking in the main repository as well.
Personally, I don't see any harm in adding the types over time, and work
towards coverage, starting with the public functions because they add the most
value.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
