Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/569#discussion_r12027664
  
    --- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
    @@ -1058,6 +1057,12 @@ private[spark] object Utils extends Logging {
       }
     
       /**
    +   * return true if this is Windows.
    +   */
    +  def isWindows = Option(System.getProperty("os.name")).
    --- End diff --
    
    Regarding `SecurityException`, `System.getProperty` will often be 
disallowed in an environment where the security manager has been enabled. I 
strongly suspect that the rest of Spark fails already in such an environment 
for other reasons, and you could argue that the only reasonable response here 
is to fail rather than "guess" that the environment is not Windows. But I put 
it in mostly to mimic `SystemUtils`. It could go either way.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to