frankyin-factual commented on a change in pull request #28898:
URL: https://github.com/apache/spark/pull/28898#discussion_r458546414
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/NestedColumnAliasingSuite.scala
##########
@@ -493,6 +491,144 @@ class NestedColumnAliasingSuite extends SchemaPruningTest
{
comparePlans(optimized3, expected3)
}
+ test("Nested field pruning for Window") {
+ val spec = windowSpec($"address" :: Nil, $"id".asc :: Nil,
UnspecifiedFrame)
+ val winExpr = windowExpr(RowNumber(), spec)
+ val query = contact
+ .select($"name.first", winExpr.as('window))
+ .orderBy($"name.last".asc)
+ .analyze
+ val optimized = Optimize.execute(query)
+ val aliases = collectGeneratedAliases(optimized)
+ val expected = contact
+ .select($"name.first", $"address", $"id", $"name.last".as(aliases(1)))
+ .window(Seq(winExpr.as("window")), Seq($"address"), Seq($"id".asc))
+ .select($"first", $"window", $"${aliases(1)}".as(aliases(0)))
+ .orderBy($"${aliases(0)}".asc)
+ .select($"first", $"window")
+ .analyze
+ comparePlans(optimized, expected)
+ }
+
+ test("Nested field pruning for Filter with other operators") {
+ val spec = windowSpec($"address" :: Nil, $"id".asc :: Nil,
UnspecifiedFrame)
+ val winExpr = windowExpr(RowNumber(), spec)
+ val query1 = contact.select($"name.first", winExpr.as('window))
+ .where($"window" === 1 && $"name.first" === "a")
+ .analyze
+ val optimized1 = Optimize.execute(query1)
+ val aliases1 = collectGeneratedAliases(optimized1)
+ val expected1 = contact
+ .select($"name.first", $"address", $"id", $"name.first".as(aliases1(1)))
+ .window(Seq(winExpr.as("window")), Seq($"address"), Seq($"id".asc))
+ .select($"first", $"${aliases1(1)}".as(aliases1(0)), $"window")
+ .where($"window" === 1 && $"${aliases1(0)}" === "a")
+ .select($"first", $"window")
+ .analyze
+ comparePlans(optimized1, expected1)
Review comment:
This is to test Filter->Window combination, so I think it fits more with
the test description. The `test("Nested field pruning for Window")` is to test
for `Windows` operators alone.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
