cloud-fan commented on a change in pull request #29160:
URL: https://github.com/apache/spark/pull/29160#discussion_r458624656
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala
##########
@@ -114,7 +114,7 @@ class DataFrameReader private[sql](sparkSession:
SparkSession) extends Logging {
* @since 1.4.0
*/
def option(key: String, value: String): DataFrameReader = {
- this.extraOptions += (key -> value)
Review comment:
but `++` is inefficient: we create an intermediate map for no reason.
I don't think changing the return type of `+` is a breaking change.
`CaseInsensitiveMap` is a private class. When we pass it to DS V1, it becomes
`Map[String, String]`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
