cloud-fan commented on a change in pull request #29107:
URL: https://github.com/apache/spark/pull/29107#discussion_r458634082
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/PropagateEmptyRelation.scala
##########
@@ -50,7 +50,7 @@ object PropagateEmptyRelation extends Rule[LogicalPlan] with
PredicateHelper wit
override def conf: SQLConf = SQLConf.get
def apply(plan: LogicalPlan): LogicalPlan = plan transformUp {
- case p @ Union(children) if children.exists(isEmptyLocalRelation) =>
+ case p @ Union(children, _, _) if children.exists(isEmptyLocalRelation) =>
Review comment:
shall we skip if by-name resolution is not finished? Otherwise the final
output schema can be indeterministic, if some children are empty relation and
get removed before participating the by-name resolution.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
