Github user hunglin commented on a diff in the pull request:
https://github.com/apache/spark/pull/5124#discussion_r27305215
--- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
@@ -474,13 +477,13 @@ class SparkContext(config: SparkConf) extends Logging
with ExecutorAllocationCli
* Spark fair scheduler pool.
*/
def setLocalProperty(key: String, value: String) {
- if (localProperties.get() == null) {
- localProperties.set(new Properties())
+ if (localProperties.get().isEmpty) {
+ localProperties.set(Some(new Properties()))
--- End diff --
@JoshRosen the idea is to use Option so compiler can help us prevent
NullPointerException. And by eagerly setting localProperties to None,
localProperties won't be null. As a contributor, when I see the type is
Option[Properties], I know I'm safe from NPE, because I might not aware of the
eagerly setting to empty Properties somewhere in the codes, and end up putting
all ```if (localProperties.get != null)``` code everywhere. If we can change
DeveloperApi, I would like to change all ```properties = null``` to Option.
That's just my 2 cents, I'm more than happy to discuss and listen to your
thoughts.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
