MaxGekk commented on a change in pull request #29145:
URL: https://github.com/apache/spark/pull/29145#discussion_r458783122
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/OrderedFilters.scala
##########
@@ -94,7 +91,7 @@ class CSVFilters(filters: Seq[sources.Filter],
requiredSchema: StructType)
predicate != null && !predicate.eval(row)
Review comment:
> Max, should we maybe add a variable that increase one by one and
assert against index?
Yeh, we can add such assert. By the way, both users of the class - CSV and
Avro have a loop in which we iterate over schema field indexes from 0 to
`index`. The assert will never trigger actually. It could be useful when you
are going to support filters pushdown for new datasource, and just accidentally
use the ordered filters but this is mostly a design issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
