agrawaldevesh commented on pull request #29032: URL: https://github.com/apache/spark/pull/29032#issuecomment-662828785
> Merged, thanks everyone. > > I don't know if we have a good principle around naming host v. worker with the deprecation. Thanks @holdenk for championing and shepherding this change !! @cloud-fan, I agree that this host <=> worker naming is confusing. It was especially confusing for a newcomer to me: `ExecutorProcessLost` has a field `workerLost` (renamed from the erstwhile `slaveLost`). I had to pick b/w `Worker` and `Host` in `ExecutorDecommissionInfo.isHostDecommissioned` and I went with `Worker` initially but later changed `Host`. But in my mind, they are both the same: Basically there is one external shuffle service (if any) per worker (or host). The word `worker` might draw some unintended connotation to the Standalone mode so I refrained from using it. But I think its usage is quite pervasive already. It would be nice to have consistent terminology around `worker` vs `host` vs `node` :-P. In the absence of any, I went with `host` here. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
