dongjoon-hyun commented on a change in pull request #29191:
URL: https://github.com/apache/spark/pull/29191#discussion_r459225681
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala
##########
@@ -361,7 +361,7 @@ class DataFrameReader private[sql](sparkSession:
SparkSession) extends Logging {
connectionProperties: Properties): DataFrame = {
assertNoSpecifiedSchema("jdbc")
// connectionProperties should override settings in extraOptions.
- val params = extraOptions.toMap ++ connectionProperties.asScala.toMap
+ val params = extraOptions ++ connectionProperties.asScala
Review comment:
`extraOptions ++ connectionProperties.asScala` will guarantee that
`connectionProoperties` overrides the `extraOption`. We added
`CaseInsensitiveMap.++` operation for that~
Also, `new JDBCOptions(url, table, params)` works like the following. The
passed `params: CaseInsensitiveMap` guarantees that JDBC_URL and
JDBC_TABLE_NAME override `parameters`.
```scala
def this(url: String, table: String, parameters: Map[String, String]) = {
this(CaseInsensitiveMap(parameters ++ Map(
JDBCOptions.JDBC_URL -> url,
JDBCOptions.JDBC_TABLE_NAME -> table)))
}
```
The above code is for your logic.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
