Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/5206#issuecomment-87061731
LGTM. I suppose that we could add a regression test for this, which might
be as simple as calling `udf()` on a partial function. This could go into
`pyspark/sql/tests.py` in the `SQLTests` class (I'd add a new method named
`test_udf_with_partial_function`; here's a link to the relevant part of the
test suite:
https://github.com/apache/spark/blob/887e1b72dfa5965f8ab1aad212fb33bb365b0e1b/python/pyspark/sql/tests.py#L117).
Also, I noticed that this was opened against `branch-1.3`. That's fine for
now, but in general we should open these sorts of pull requests against
`master`, since this patch should be applied for both 1.4.0 and 1.3.1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
