cloud-fan commented on a change in pull request #29181:
URL: https://github.com/apache/spark/pull/29181#discussion_r459470276
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashJoin.scala
##########
@@ -54,6 +54,8 @@ trait HashJoin extends BaseJoinExec {
override def outputPartitioning: Partitioning =
streamedPlan.outputPartitioning
+ override def outputOrdering: Seq[SortOrder] = streamedPlan.outputOrdering
Review comment:
to be future-proof, we should only do it if the join type allows us to
do so. It's fragile to rely on what the join type can be in hash join.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
