srowen commented on a change in pull request #29196:
URL: https://github.com/apache/spark/pull/29196#discussion_r459498866
##########
File path: pom.xml
##########
@@ -892,7 +907,25 @@
<dependency>
<groupId>org.scalatest</groupId>
<artifactId>scalatest_${scala.binary.version}</artifactId>
- <version>3.0.8</version>
+ <version>3.2.0</version>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.scalatestplus</groupId>
+
<artifactId>scalatestplus-scalacheck_${scala.binary.version}</artifactId>
+ <version>3.1.0.0-RC2</version>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.scalatestplus</groupId>
+ <artifactId>scalatestplus-mockito_${scala.binary.version}</artifactId>
+ <version>1.0.0-SNAP5</version>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.scalatestplus</groupId>
+ <artifactId>scalatestplus-selenium_${scala.binary.version}</artifactId>
+ <version>1.0.0-SNAP5</version>
Review comment:
Weird, yeah. Updating objenesis is probably fine. Downgrading okio (?)
maybe not.
- hadoop-hdfs-client pulls in okhttp 2.7.5 which depends on okio 1.6.0
- io.fabric8 (used in K8S) pulls in okhttp 3.12.6 and okio 1.15.0
- scalatest-selenium (new) pulls in okhttp 3.11.0 and okio 1.14.0
We actually have both okhttp 2 and 3 in the Hadoop 3 deps! maybe this is OK
It may be that it's OK for the assembly to land on 1.14.0 - managed up much
more from Hadoop's version than down from the fabric8 version. That fabric8
update happened relatively recently, but in 3.0.0:
https://github.com/apache/spark/commit/78bdcfade1898ecbde3db4542cac6b29f88eb26c
We can manage it (and okhttp) explicitly but is it worth it?
Well I'll push the dep updates anyway. Looks like it passed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
