Github user pwendell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5225#discussion_r27328262
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrame.scala ---
    @@ -730,6 +731,23 @@ class DataFrame private[sql](
         Generate(generator, join = true, outer = false, None, logicalPlan)
       }
     
    +  /**
    +   * Returns a new [[DataFrame]] that omits rows with `NULL` values in the 
specified columns.
    +   * If no columns are specified, a row is omitted if any column contains 
`NULL`.
    +   *
    +   * @group dfops
    +   */
    +  @scala.annotation.varargs
    +  def dropna(cols: String*): DataFrame = {
    --- End diff --
    
    Is it possible to do what cheng said? I think dropNull is a much better 
name, but if we have an alias dropna, I think it would be good for pandas 
compatibility. In general I think aliasing things might necessary in the way we 
approach data frames since we're trying to meet a few different requirements.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to