viirya commented on a change in pull request #29208:
URL: https://github.com/apache/spark/pull/29208#discussion_r459725002
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
##########
@@ -3078,6 +3078,30 @@ class SQLQuerySuite extends QueryTest with
SharedSQLContext {
checkAnswer(df, Row(1))
}
}
+
+ test("SPARK-32372: ResolveReferences.dedupRight should only rewrite
attributes for ancestor " +
+ "plans of the conflict plan") {
+ sql("SELECT name, avg(age) as avg_age FROM person GROUP BY name")
+ .createOrReplaceTempView("person_a")
+ sql("SELECT p1.name, p2.avg_age FROM person p1 JOIN person_a p2 ON p1.name
= p2.name")
+ .createOrReplaceTempView("person_b")
+ sql("SELECT * FROM person_a UNION SELECT * FROM person_b")
+ .createOrReplaceTempView("person_c")
+ checkAnswer(
+ sql("SELECT p1.name, p2.avg_age FROM person_c p1 JOIN person_c p2 ON
p1.name = p2.name"),
+ Row("jim", 20.0) :: Row("mike", 30.0) :: Nil)
+ }
+
+ test("SPARK-32280: Avoid duplicate rewrite attributes when there're multiple
JOINs") {
+ withSQLConf(SQLConf.CROSS_JOINS_ENABLED.key -> "true") {
Review comment:
Original PR doesn't need to enable this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
