shaneknapp commented on pull request #28594:
URL: https://github.com/apache/spark/pull/28594#issuecomment-663263741


   > Sure, I totally see the need for an `--exclude-tag`, but the default or 
current behavior of the integration tests now skips over the SparkR 
test:[example](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/30887/console).
 This has been a side-effect of this change.
   
   the specific bits to look at are towards the end of the build...  right 
above `KubernetesSuite`, we build the spark-r image, and the new behavior 
introduced by this PR then skips the actual integration test against that image 
within `KubernetesSuite`.
   
   > By default (=if you don't use --exclude-tags r), the test coverage is 
unchanged in the community so far.
   
   @dongjoon-hyun this is the exact command used by the 
SparkPullRequestBuilder-K8s job to launch the integration tests.  we are not 
using `--exclude-tags`.
   
   ```
   
resource-managers/kubernetes/integration-tests/dev/dev-run-integration-tests.sh 
\
       $JAVA_MVN_FLAG --spark-tgz ${WORKSPACE}/spark-*.tgz
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to