holdenk commented on pull request #29180: URL: https://github.com/apache/spark/pull/29180#issuecomment-663319198
> It is getting popular and more stable but the typing hint is still being evolved even between the minor versions. See https://docs.python.org/3/library/typing.html. One example might be [PEP 544](https://www.python.org/dev/peps/pep-0544/) that allows structural subtyping (Python 3.8). It could change the fundamental way of how we type. That's from three years ago. Scala type system has certainly evolved more than once every three years. > > I don't strongly object to have the codes inlined but I would think it's more safer and easier way to port the files first. Ok sounds like that's our path forward then if @Fokko , @zero323 and other folks are K with that? > > > How should we best keep the type hints up to date if it's in a seperate file? > > Could we add something to the PR templated for Python requests? > > As for a separate repo what do you envision? > > I am sure we will figure a way out. For example, > > * We could take NumPy approach e.g. [numpy/**init**.pyi](https://github.com/numpy/numpy/blob/master/numpy/__init__.pyi). Isn't that the same repo? Or am I missing something? > * Or we can port his repo to ASF (is it feasible?). It would mean going through the incubation process. Which is doable, but rather a lot of work and not something I would suggest someone else up to do if I wanted them to talk to me again. That being said if we don't have a consesus on bringing it in tree in some form, I'd be happy to serve as one of the mentors for incubation (but I'd rather not have the types in a seperate project). > > I think IDE can detect. If I am not mistaken, mypy can detect too as a linter. If dev people find it confusing, we should maybe document it in PR template as you suggest or in the contribution guide. Sounds good to me :) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
