HyukjinKwon opened a new pull request #29215:
URL: https://github.com/apache/spark/pull/29215


   ### What changes were proposed in this pull request?
   
   This PR backports https://github.com/apache/spark/pull/29117 to branch-3.0 
as the flakiness was found in branch-3.0 too: 
https://github.com/apache/spark/pull/29201#issuecomment-663114741 and 
https://github.com/apache/spark/pull/29201#issuecomment-663114741
   
   This PR proposes:
   
   - ~~Don't use `--user` in pip packaging test~~
   - ~~Pull `source` out of the subshell, and place it first.~~
   - Exclude user sitepackages in Python path during pip installation test
   
   to address the flakiness of the pip packaging test in Jenkins.
   
   ~~(I think) #29116 caused this flakiness given my observation in the Jenkins 
log. I had to work around by specifying `--user` but it turned out that it does 
not properly work in old Conda on Jenkins for some reasons. Therefore, 
reverting this change back.~~
   
   (I think) the installation at user site-packages affects other environments 
created by Conda in the old Conda version that Jenkins has. Seems it fails to 
isolate the environments for some reasons. So, it excludes user sitepackages in 
the Python path during the test.
   
   ~~In addition, #29116 also added some fallback logics of `conda 
(de)activate` and `source (de)activate` because Conda prefers to use `conda 
(de)activate` now per the official documentation and `source (de)activate` 
doesn't work for some reasons in certain environments (see also 
https://github.com/conda/conda/issues/7980). The problem was that `source` 
loads things to the current shell so does not affect the current shell. 
Therefore, this PR pulls `source` out of the subshell.~~
   
   Disclaimer: I made the analysis purely based on Jenkins machine's log in 
this PR. It may have a different reason I missed during my observation.
   
   ### Why are the changes needed?
   
   To make the build and tests pass in Jenkins.
   
   ### Does this PR introduce _any_ user-facing change?
   
   No, dev-only.
   
   ### How was this patch tested?
   
   Jenkins tests should test it out.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to