dongjoon-hyun commented on a change in pull request #29203:
URL: https://github.com/apache/spark/pull/29203#discussion_r459835409



##########
File path: core/src/main/scala/org/apache/spark/metrics/MetricsSystem.scala
##########
@@ -101,8 +101,8 @@ private[spark] class MetricsSystem private (
     running = true
     if (registerStaticSources) {
       StaticSources.allSources.foreach(registerSource)
-      registerSources()
     }
+    registerSources()

Review comment:
       This is a partial revert of another your previous commit, 
https://github.com/apache/spark/pull/22279, two year ago, isn't it?
   ```
   [SPARK-25277][YARN] YARN applicationMaster metrics should not register 
static metrics
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to