HyukjinKwon commented on a change in pull request #29212:
URL: https://github.com/apache/spark/pull/29212#discussion_r459836418
##########
File path: dev/run-pip-tests
##########
@@ -85,7 +85,7 @@ for python in "${PYTHON_EXECS[@]}"; do
source "$CONDA_PREFIX/etc/profile.d/conda.sh"
fi
conda create -y -p "$VIRTUALENV_PATH" python=$python numpy pandas pip
setuptools
- source activate "$VIRTUALENV_PATH" || (echo "Falling back to 'conda
activate'" && conda activate "$VIRTUALENV_PATH")
+ source activate "$VIRTUALENV_PATH" || conda activate "$VIRTUALENV_PATH"
Review comment:
I tested as below in my local:
```bash
➜ spark git:(master) python
Python 3.7.7 (default, Mar 10 2020, 15:43:03)
[Clang 11.0.0 (clang-1100.0.33.17)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> exit(0)
```
```
➜ spark git:(master) source activate koalas-dev-env || (echo "a" && conda
activate koalas-dev-env)
source: no such file or directory: activate
a
```
```
➜ spark git:(master) python
Python 3.7.7 (default, Mar 10 2020, 15:43:03)
[Clang 11.0.0 (clang-1100.0.33.17)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> exit(0)
```
```
➜ spark git:(master) source activate koalas-dev-env || conda activate
koalas-dev-env
source: no such file or directory: activate
```
```
➜ spark git:(master) python
Python 3.6.10 |Anaconda, Inc.| (default, May 7 2020, 23:06:31)
[GCC 4.2.1 Compatible Clang 4.0.1 (tags/RELEASE_401/final)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> exit(0)
```
```
➜ spark git:(master) source deactivate || (echo "a" && conda deactivate)
source: no such file or directory: deactivate
a
```
```
➜ spark git:(master) python
Python 3.6.10 |Anaconda, Inc.| (default, May 7 2020, 23:06:31)
[GCC 4.2.1 Compatible Clang 4.0.1 (tags/RELEASE_401/final)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> exit(0)
```
```
➜ spark git:(master) source deactivate || conda deactivate
source: no such file or directory: deactivate
```
```
➜ spark git:(master) python
Python 3.7.7 (default, Mar 10 2020, 15:43:03)
[Clang 11.0.0 (clang-1100.0.33.17)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> exit(0)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
