cloud-fan commented on a change in pull request #29198:
URL: https://github.com/apache/spark/pull/29198#discussion_r459848829
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
##########
@@ -3610,8 +3610,10 @@ class AstBuilder(conf: SQLConf) extends
SqlBaseBaseVisitor[AnyRef] with Logging
case Some(x) => throw new ParseException(s"SHOW $x FUNCTIONS not
supported", ctx)
}
val pattern = Option(ctx.pattern).map(string(_))
- val functionName =
Option(ctx.multipartIdentifier).map(visitMultipartIdentifier)
- ShowFunctionsStatement(userScope, systemScope, pattern, functionName)
+ val functionName = Option(ctx.multipartIdentifier)
Review comment:
nit: maybe `unresolvedFun`? it's not a name anymore.
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
##########
@@ -3610,8 +3610,10 @@ class AstBuilder(conf: SQLConf) extends
SqlBaseBaseVisitor[AnyRef] with Logging
case Some(x) => throw new ParseException(s"SHOW $x FUNCTIONS not
supported", ctx)
}
val pattern = Option(ctx.pattern).map(string(_))
- val functionName =
Option(ctx.multipartIdentifier).map(visitMultipartIdentifier)
- ShowFunctionsStatement(userScope, systemScope, pattern, functionName)
+ val functionName = Option(ctx.multipartIdentifier)
Review comment:
nit: maybe `unresolvedFunc`? it's not a name anymore.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
