Ngone51 commented on a change in pull request #28911:
URL: https://github.com/apache/spark/pull/28911#discussion_r459897266
##########
File path: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
##########
@@ -492,20 +494,26 @@ private[spark] class BlockManager(
registerWithExternalShuffleServer()
}
- hostLocalDirManager =
- if (conf.get(config.SHUFFLE_HOST_LOCAL_DISK_READING_ENABLED) &&
- !conf.get(config.SHUFFLE_USE_OLD_FETCH_PROTOCOL)) {
- externalBlockStoreClient.map { blockStoreClient =>
- new HostLocalDirManager(
- futureExecutionContext,
- conf.get(config.STORAGE_LOCAL_DISK_BY_EXECUTORS_CACHE_SIZE),
- blockStoreClient,
- blockManagerId.host,
- externalShuffleServicePort)
- }
+ hostLocalDirManager = {
+ val canUseHostLocalReading =
conf.get(config.SHUFFLE_HOST_LOCAL_DISK_READING_ENABLED) &&
+ !conf.get(config.SHUFFLE_USE_OLD_FETCH_PROTOCOL)
+ val externalShuffleServiceEnabled = externalBlockStoreClient.isDefined
+ val dynamicAllocationDisabled = !conf.get(config.DYN_ALLOCATION_ENABLED)
+ val dynamicAllocationEnabledWithShuffleTacking =
conf.get(config.DYN_ALLOCATION_ENABLED) &&
+ conf.get(config.DYN_ALLOCATION_SHUFFLE_TRACKING_ENABLED)
Review comment:
Thanks for catching it!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
