Github user debasish83 commented on the pull request:
https://github.com/apache/spark/pull/3221#issuecomment-87165211
I integrated with Breeze 0.11.2. Only visible difference is first iteration
Breeze QuadraticMinimizer:
TUSCA09LMLVT00C:spark-qp-als v606014$ grep solveTime
./work/app-20150327221722-0000/0/stderr
15/03/27 22:17:32 INFO ALS: solveTime 234.153 ms
15/03/27 22:17:32 INFO ALS: solveTime 82.499 ms
15/03/27 22:17:33 INFO ALS: solveTime 83.579 ms
15/03/27 22:17:33 INFO ALS: solveTime 83.039 ms
15/03/27 22:17:34 INFO ALS: solveTime 35.545 ms
15/03/27 22:17:34 INFO ALS: solveTime 30.707 ms
15/03/27 22:17:35 INFO ALS: solveTime 53.025 ms
15/03/27 22:17:36 INFO ALS: solveTime 53.021 ms
15/03/27 22:17:36 INFO ALS: solveTime 31.329 ms
15/03/27 22:17:37 INFO ALS: solveTime 32.136 ms
mllib CholeskySolver:
TUSCA09LMLVT00C:spark-qp-als v606014$ grep solveTime
./work/app-20150327221/0/stderr
app-20150327221722-0000/ app-20150327221803-0001/
TUSCA09LMLVT00C:spark-qp-als v606014$ grep solveTime
./work/app-20150327221803-0001/0/stderr
15/03/27 22:18:11 INFO ALS: solveTime 98.692 ms
15/03/27 22:18:12 INFO ALS: solveTime 38.997 ms
15/03/27 22:18:12 INFO ALS: solveTime 62.361 ms
15/03/27 22:18:13 INFO ALS: solveTime 60.316 ms
15/03/27 22:18:13 INFO ALS: solveTime 36.569 ms
15/03/27 22:18:14 INFO ALS: solveTime 36.321 ms
15/03/27 22:18:14 INFO ALS: solveTime 60.007 ms
15/03/27 22:18:15 INFO ALS: solveTime 59.771 ms
15/03/27 22:18:15 INFO ALS: solveTime 36.519 ms
15/03/27 22:18:16 INFO ALS: solveTime 38.295 ms
Visible difference is in first 2 iterations as showed in previous
experiments as well. I fixed the random seed test now and so different runs
will not produce the same result.
I need this structure to build ALM as ALM extends mllib.ALS and adds
LossType in constructor along with userConstraint and itemConstraint...
Right now I am experimenting with LeastSquare (for tests with ALS) and I am
experimenting with LeastSquare and LogLikelihood loss...
For this PR I have updated MovieLensALS with userConstraint and
itemConstraint and I am considering if we should add a Sparse Coding
formulation in examples now or we bring that in a separate PR ?
I have not cleaned up CholeskySolver from ALS yet and waiting for the
feedbacks but I have added test-cases in ml.ALSSuite for all the
constraints....At ALS flow level I need to construct more test-cases and I can
bring them in separate PR as well...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
