c21 commented on a change in pull request #29216:
URL: https://github.com/apache/spark/pull/29216#discussion_r460318542
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashJoin.scala
##########
@@ -172,14 +208,26 @@ trait HashJoin extends BaseJoinExec {
val joinKeys = streamSideKeyGenerator()
val result = new GenericInternalRow(Array[Any](null))
val joinedRow = new JoinedRow
- streamIter.map { current =>
- val key = joinKeys(current)
- lazy val buildIter = hashedRelation.get(key)
- val exists = !key.anyNull && buildIter != null && (condition.isEmpty ||
buildIter.exists {
- (row: InternalRow) => boundCondition(joinedRow(current, row))
- })
- result.setBoolean(0, exists)
- joinedRow(current, result)
+
Review comment:
@viirya - existence join is tricky and I will try to add one. But
besides testing, wondering what do you think of this PR? Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
