HyukjinKwon opened a new pull request #29229:
URL: https://github.com/apache/spark/pull/29229


   ### What changes were proposed in this pull request?
   
   This PR removes the manual port of `heapq3.py` introduced from SPARK-3073. 
The main reason of this was to support Python 2.6 and 2.7 because Python 2's 
heapq.merge() do not support `key` and `reverse`.
   
   See
   - https://docs.python.org/2/library/heapq.html#heapq.merge in Python 2
   - https://docs.python.org/3.8/library/heapq.html#heapq.merge in Python 3
   
   Since we dropped the Python 2 at SPARK-32138, we can remove this away.
   
   ### Why are the changes needed?
   
   To remove unnecessary codes. Also, we can leverage bug fixes made in Python 
3.x at `heapq`.
   
   ### Does this PR introduce _any_ user-facing change?
   
   No, dev-only. 
   
   ### How was this patch tested?
   
   Existing tests should cover. I locally ran and verified:
   
   ```bash
   ./python/run-tests --python-executable=python3 
--testname="pyspark.tests.test_shuffle"
   ./python/run-tests --python-executable=python3 --testname="pyspark.shuffle 
ExternalSorter"
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to