Github user srowen commented on the pull request:

    https://github.com/apache/spark/pull/546#issuecomment-41503775
  
    Agree and that leads to the changes. For example `HttpBroadcast.scala` adds 
paths to the set using the string from `getAbsolutePath` (line 173) but removes 
them with the value of `toString`, which is `getPath`, which is not necessarily 
the same. (It may happen to be here.) Seems better to be consistent. In 
`DiskBlockManagerSuite.scala` I also don't see we have a guarantee that the 
path is absolute, and it needs to be IIUC, and the OP suggests this doesn't 
actually work in some cases.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to