HyukjinKwon commented on a change in pull request #29232:
URL: https://github.com/apache/spark/pull/29232#discussion_r460629686
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcUtils.scala
##########
@@ -207,10 +207,19 @@ object OrcUtils extends Logging {
}
/**
- * @return Returns the result schema string based on the canPruneCols flag.
- * resultSchemaString will be created using resultsSchema in case of
- * canPruneCols is true and for canPruneCols as false value
- * resultSchemaString will be created using the actual dataSchema.
+ * This method returns the result schema as string based on the canPruneCols
flag.
Review comment:
I would just write as:
Returns the result schema to read from ORC file. In addition, It sets the
schema string to 'orc.mapred.input.schema' so ORC readers can use later.
and inline the details about parameters into the parameter descriptions
below.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
