cloud-fan commented on a change in pull request #29204:
URL: https://github.com/apache/spark/pull/29204#discussion_r460641290
##########
File path:
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkOperation.scala
##########
@@ -35,7 +37,7 @@ private[hive] trait SparkOperation extends Operation with
Logging {
protected def sqlContext: SQLContext
- protected var statementId =
getHandle().getHandleIdentifier().getPublicId().toString()
+ protected val statementId: String = getHandle.getHandleIdentifier.toString
Review comment:
Can we revert this change? I see places that use `statementId =
UUID.randomUUID().toString`. It's better to have a separated PR to unify this
part.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]