attilapiros edited a comment on pull request #29226: URL: https://github.com/apache/spark/pull/29226#issuecomment-664108813
We are still not there yet. So according to you analyses: > - We wait 300 ms and decommission executor 0. > > - If the task is not yet done on executor 0, it will now fail because the block manager won't be able to save the block. This condition is easy to trigger on a loaded machine where the github checks run. If we would need this block to be saved then there would be a much simpler fix by checking when the block appears in the `blocksUpdated` collection. ~~But this goes against the `migrateDuring` original intention (see the first comment):~~ https://github.com/apache/spark/blob/913e6d72c0bb3b18739b730a0634bcbc35444437/core/src/test/scala/org/apache/spark/storage/BlockManagerDecommissionIntegrationSuite.scala#L157-L164 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
