HyukjinKwon commented on a change in pull request #29241:
URL: https://github.com/apache/spark/pull/29241#discussion_r460689868



##########
File path: core/src/main/scala/org/apache/spark/TestUtils.scala
##########
@@ -236,7 +236,11 @@ private[spark] object TestUtils {
    * Test if a command is available.
    */
   def testCommandAvailable(command: String): Boolean = {
-    val attempt = Try(Process(command).run(ProcessLogger(_ => ())).exitValue())
+    val attempt = if (Utils.isWindows) {
+      Try(Process(s"WHERE $command").run(ProcessLogger(_ => ())).exitValue())

Review comment:
       I run some tests via AppVeyor manually to show it works in Windows:
   
   Build started: [CORE] `org.apache.spark.rdd.PipedRDDSuite` 
[![PR-29241](https://ci.appveyor.com/api/projects/status/github/HyukjinKwon/spark?branch=5D8964EE-6046-4DBA-91AD-53B2E5EE4500&svg=true)](https://ci.appveyor.com/project/HyukjinKwon/spark/branch/5D8964EE-6046-4DBA-91AD-53B2E5EE4500)
   
   Build started: [SQL] `org.apache.spark.sql.hive.execution.SQLQuerySuite` 
[![PR-29241](https://ci.appveyor.com/api/projects/status/github/HyukjinKwon/spark?branch=C22F6129-6D78-40AF-BE21-1A625BC656A1&svg=true)](https://ci.appveyor.com/project/HyukjinKwon/spark/branch/C22F6129-6D78-40AF-BE21-1A625BC656A1)
   
   Some of tests might already fail. We can just see if `testCommandAvailable` 
works or not.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to